[video_player] Issue 166411 preferred audio language support for player creation#12152
[video_player] Issue 166411 preferred audio language support for player creation#12152Zubii12 wants to merge 7 commits into
Conversation
Zubii12
force-pushed
the
issue-166411-preferred-audio-language
branch
from
2afe303 to
b0a4aa6
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring a preferred audio language during player creation via VideoPlayerOptions.preferredAudioLanguage across the video_player federated packages. The changes update the platform interface, forward the option during player initialization, and implement native track selection for Android (ExoPlayer) and iOS/macOS (AVFoundation). Unit tests and changelogs are updated accordingly. There are no review comments, so no additional feedback is provided.
Zubii12
force-pushed
the
issue-166411-preferred-audio-language
branch
4 times, most recently
from
ce1bb95 to
0db81a5
Compare
stuartmorgan-g
added
the
federated: all_changes
…orm API and players
Zubii12
force-pushed
the
issue-166411-preferred-audio-language
branch
from
0db81a5 to
2b0f2e6
Compare
| @@ -1,3 +1,7 @@ | |||
| ## 6.10.0 | |||
|
|
|||
| * Adds `videoPlayerOptions` to `VideoCreationOptions` to allow platform implementations to receive per-player options at creation time. | |||
There was a problem hiding this comment.
This doesn't appear to be what is happening in this sub package.
| @@ -1,3 +1,7 @@ | |||
| ## 2.14.0 | |||
|
|
|||
| * Forwards `VideoPlayerOptions.preferredAudioLanguage` during player creation so platform implementations can apply the preferred audio language per player instance. | |||
There was a problem hiding this comment.
it doesn't seem like anything changed in this sub package, so a version bump and changelog aren't needed
tarrinneal
added
triage-ios
3 participants
Adds preferredAudioLanguage to platform interface options and forwards it during player creation
Fixes flutter/flutter#166411
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2